ci: let a manually triggered run actually deploy - #54
Merged
Conversation
The deploy job was gated on `github.event_name == 'push'`. A manual run therefore built and then skipped the deploy, so the manual trigger could not redeploy, which is the only reason it exists. Gate on `!= 'pull_request'` instead. A pull request must still build without publishing; every other trigger deploys, so adding a trigger above cannot silently produce a build-only run again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy job was gated on
github.event_name == 'push'. A manual run therefore built and then skipped the deploy, so the manual trigger could not redeploy, which is the only reason it exists. Measured on a dispatch run:Build & Check: success,Deploy to GitHub Pages: skipped.Changes
github.event_name != 'pull_request'instead of== 'push'.A pull request must still build without publishing. Every other trigger deploys, so a trigger added later cannot silently produce a build-only run.
Test plan
workflow_dispatchrun reachesDeploy to GitHub Pages: success.